Fix new_return_no_self with recursive bounds #10086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @llogiq (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
matthiaskrgr
approved these changes
Dec 16, 2022
|
@bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
This was referenced Dec 16, 2022
dswij
added
the
beta-nominated
|
@flip1995 IIRC, we agreed this should be backported in Zulip. I've added the label, but let me know if this is not the case. |
|
Thanks for taking care of this! I'll will do the backport in the next few days. Good thing, I didn't have time to do the sync yesterday, so that gets in earlier 😅 |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 31, 2022
…ulacrum [beta] backport clippy stack overflow fix Backports rust-lang/rust-clippy#10086 to the beta branch where the bug is still present. I just cherry-picked the commit. cc `@rust-lang/clippy`
flip1995
added
beta-accepted
xFrednet
removed
the
beta-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10041
This uses a hash set, as described in #10068 (comment)
changelog: [
new_return_no_self]: fix stack overflow when the return type isimpl Traitand contains recursive bounds