Suggest using Path for comparing extensions

[tylerjw]

fixes #10042

changelog: Sugg: [case_sensitive_file_extension_comparisons]: Now displays a suggestion with Path
#10107

[rustbot]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Alexendoo (or someone else) soon.

Please see the contribution instructions for more information.

[tylerjw]

I'm could use some mentoring on what to do next about this PR.

1. Should I be using string operations to build the suggestion or using something like fold from rustc? The idea would be to traverse recv and remove method calls to_lowercase and to_uppercase. I looked into doing this and could not hack this together so it would work or find any examples of similar things in clippy. Advice here would be really helpful.

2. On creating a multi-line suggestion. My current approach seems to hard-code the indentation level. I also have a copy of this that makes this a single-line change, but the result is a diagnostic that runs off the right side of my terminal. Is there tooling for creating multi-line suggestions that have the correct indentation, look good in the terminal output, and are not too far from what rustfmt would like?

[Alexendoo]

Hi, sorry for taking a while to get to this

For 1. I would say no, removing a trailing .to_lowercase()/.to_uppercase() is the only place it can be done safely without other checks that are overkill since it wouldn't be that common, e.g. in f(s.to_lowercase()).ends_with(".txt") we don't know what's going to happen in f

For 2. you could look at using snippet_indent or reindent_multiline + indent_of

[tylerjw]

Thank you for the reply. Are you saying I should adjust this PR to only remove the to_lowercase call in the case where it is at the end of the recv code snippet? That makes allot of sense as the only place where it is safe to do this in. Should I still provide a diagnostic about maybe removing it when I detect it in the line but not at the end?

[tylerjw]

@Alexendoo I updated this PR based on your feedback. Let me know if you would like me to change anything. Thank you again for the links for indenting, that was easy to fixup once I knew about those functions.

I made my new changes a separate commit so it is easier for you to review them. If you'd like me to I'm happy to rebase this PR into a single commit. I don't know what is the norm for this project.

[tylerjw]

I've applied the changes you suggested and tested them. Let me know if I did it correctly and if you'd like any more changes. Thank you for the review.

[Alexendoo]

Yep looks great thanks!

@bors r+

[bors]

📌 Commit ea6ff7e has been approved by Alexendoo

It is now in the queue for this repository.

[bors]

⌛ Testing commit ea6ff7e with merge a385d34...

[bors]

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Alexendoo
Pushing a385d34 to master...