Add machine applicable suggestion for needless_lifetimes
#10222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @flip1995 (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
|
☔ The latest upstream changes (presumably #10257) made this pull request unmergeable. Please resolve the merge conflicts. |
flip1995
approved these changes
Jan 31, 2023
|
r=me once rebased. |
Also adds a test for rust-lang#5787
Alexendoo
force-pushed
the
needless-lifetime-suggestion
branch
from
422cc5d
to
6a8b202
Compare
|
Thank you! @bors r=flip1995 |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: [
needless_lifetimes]: Add machine applicable suggestionFixes #9360
It doesn't make suggestions for async functions as the input lifetime spans are funky there
The examples in #5787 and #7271 no longer seem to FP this PR aside, I added tests for them rather than disabling the lint entirely for async functions, I don't know if there are further FPs there though
Closes #5787
Closes #7271