Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make [clippy::dump] support trait items #10292

Merged
merged 1 commit into from Feb 9, 2023

Conversation

xFrednet
Copy link
Member

@xFrednet xFrednet commented Feb 4, 2023

Roses are red,
violets are blue,
trait items are rare,
[clippy::dump] is too


Let's just ignore the horrible poem... anyways. While working on Marker I noticed, that [clippy::dump] doesn't work on trait item (See Playground). This simply adds support for that. [clippy::dump] doesn't have UI tests, to make it more resistant to changes in the AST. I tested it locally and the dump works after these changes.


changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Feb 4, 2023

r? @flip1995

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Feb 4, 2023
@xFrednet
Copy link
Member Author

xFrednet commented Feb 4, 2023

I've noticed that it also doesn't work on the implementation of trait functions. I'll fixup the commit :)

@xFrednet xFrednet marked this pull request as draft February 4, 2023 18:32
@xFrednet xFrednet marked this pull request as ready for review February 4, 2023 18:35
@xFrednet
Copy link
Member Author

xFrednet commented Feb 4, 2023

Okay, now everything should work. I updated the changelog in the PR description :)

@flip1995
Copy link
Member

flip1995 commented Feb 9, 2023

I've noticed that it also doesn't work on the implementation of trait functions. I'll fixup the commit :)

Between this message and

Okay, now everything should work. I updated the changelog in the PR description :)

that message, you didn't push anything. What is this magic you are using? 🧙 🤔

@xFrednet xFrednet force-pushed the 0000-support-trait-item-in-dump branch from 8f4887f to c642cfe Compare February 9, 2023 13:20
@xFrednet
Copy link
Member Author

xFrednet commented Feb 9, 2023

Ups, yeah I forgot to push. Finally, I can claim "It works on my mashine" ^^

@flip1995
Copy link
Member

flip1995 commented Feb 9, 2023

That looks better!

@bors r+

Thanks!

@bors
Copy link
Collaborator

bors commented Feb 9, 2023

📌 Commit c642cfe has been approved by flip1995

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Feb 9, 2023

⌛ Testing commit c642cfe with merge 5adeebf...

@bors
Copy link
Collaborator

bors commented Feb 9, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 5adeebf to master...

@bors bors merged commit 5adeebf into rust-lang:master Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants