New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make [clippy::dump]
support trait items
#10292
Make [clippy::dump]
support trait items
#10292
Conversation
r? @flip1995 (rustbot has picked a reviewer for you, use r? to override) |
I've noticed that it also doesn't work on the implementation of trait functions. I'll fixup the commit :) |
Okay, now everything should work. I updated the changelog in the PR description :) |
Between this message and
that message, you didn't push anything. What is this magic you are using? 🧙 🤔 |
8f4887f
to
c642cfe
Compare
Ups, yeah I forgot to push. Finally, I can claim "It works on my mashine" ^^ |
That looks better! @bors r+ Thanks! |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Roses are red,
violets are blue,
trait items are rare,
[clippy::dump]
is tooLet's just ignore the horrible poem... anyways. While working on Marker I noticed, that
[clippy::dump]
doesn't work on trait item (See Playground). This simply adds support for that.[clippy::dump]
doesn't have UI tests, to make it more resistant to changes in the AST. I tested it locally and the dump works after these changes.changelog: none