[never_loop] Fix #10304 #10311
[never_loop] Fix #10304 #10311
Conversation
|
r? @Jarcho (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
samueltardieu
force-pushed
the
issue-10304
branch
from
82db08b
to
2d98685
Compare
|
Overall looks good. While you're at changing this you can remove |
Indeed, will do. |
samueltardieu
force-pushed
the
issue-10304
branch
4 times, most recently
from
346a9f2
to
758e4ce
Compare
|
It is ready now. I first removed |
`combine_seq(x, NeverLoopResult::Otherwise)` always returns `x`
All evaluations now happen in order.
The following code
```
loop {
'a: {
{ }
break 'a;
}
}
```
was detected as a never-looping loop.
It is not sufficient to ignore break from a block inside the loop. Instructions after the break must be ignored, as they are unreachable. This is also true for all instructions in outer blocks and loops until the right block is reached.
samueltardieu
force-pushed
the
issue-10304
branch
from
758e4ce
to
657ee48
Compare
|
All looks good. Thanks for the fix. @bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
It is not sufficient to ignore break from a block inside the loop. Instructions after the break must be ignored, as they are unreachable. This is also true for all instructions in outer blocks and loops until the right block is reached.
Fixes #10304
changelog: FP: [
never_loop]: No longer lints, for statements following break statements for outer blocks.#10311