Liberate late-bound regions rather than erasing them in needless_pass_by_value

[compiler-errors]

changelog: [needless_pass_by_value]: fixes an ICE when there are late-bound regions in function arguments that are needlessly passed by value

Fixes rust-lang/rust#107147
r? @matthiaskrgr

[compiler-errors]

For the record, I have no idea how to make a clippy PR, or clippy UI test for that matter. Let me know if I did something wrong -- worst case, I can always open this against the rust-lang/rust repo :^)

[matthiaskrgr]

Looks good to me, yeah, basically just create foo.rs and foo.stderr in in the test directory and that's it. :)

Just two nites:

• I would like to see the rustc ticket referenced in the .rs file so we know what this test was about, a comment like // https://github.com/rust-lang/rust/issues/107147 should do imo.
• The test can be moved into tests/ui/crashes actually

[matthiaskrgr]

Thanks!

[matthiaskrgr]

@bors r+

[bors]

📌 Commit 17cb2e4 has been approved by matthiaskrgr

It is now in the queue for this repository.

[bors]

⌛ Testing commit 17cb2e4 with merge e018a2c...

[bors]

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: matthiaskrgr
Pushing e018a2c to master...