Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manual_let_else: let/else is not divergent by default #10332

Merged
merged 1 commit into from Feb 15, 2023

Conversation

samueltardieu
Copy link
Contributor

@samueltardieu samueltardieu commented Feb 12, 2023

The divergent else block of a let/else statement does not make the let/else statement itself divergent.

Fixes #10296

changelog: [manual_let_else]: do not consider let/else to be divergent by default

@rustbot
Copy link
Collaborator

rustbot commented Feb 12, 2023

r? @Alexendoo

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Feb 12, 2023
@samueltardieu samueltardieu force-pushed the issue-10296 branch 2 times, most recently from e601691 to 5c23687 Compare February 12, 2023 13:42
The divergent `else` block of a `let`/`else` statement does not make
the `let`/`else` statement itself divergent.
@Alexendoo
Copy link
Member

Alexendoo commented Feb 14, 2023

Thanks! This is a good way of doing it 👍

@bors r+

@bors
Copy link
Collaborator

bors commented Feb 14, 2023

📌 Commit 7f15a11 has been approved by Alexendoo

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Feb 14, 2023

⌛ Testing commit 7f15a11 with merge 4c28fdd...

@bors
Copy link
Collaborator

bors commented Feb 15, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Alexendoo
Pushing 4c28fdd to master...

@bors bors merged commit 4c28fdd into rust-lang:master Feb 15, 2023
@samueltardieu samueltardieu deleted the issue-10296 branch February 19, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

manual_let_else wrong suggestion when else block doesn't diverge
4 participants