Change unusual_byte_groupings to require byte groupings of equal size #10353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Alexendoo (or someone else) soon. Please see the contribution instructions for more information. |
rustbot
added
the
S-waiting-on-review
llogiq
reviewed
Feb 16, 2023
| @@ -210,7 +210,7 @@ impl WarningType { | |||
| cx, | |||
| UNUSUAL_BYTE_GROUPINGS, | |||
| span, | |||
| "digits of hex or binary literal not grouped by four", | |||
| "digits of hex, binary or octal literal not groups of equal size", | |||
There was a problem hiding this comment.
Suggested change
| "digits of hex, binary or octal literal not groups of equal size", | |
| "digits of hex, binary or octal literal not in groups of equal size", |
llogiq
reviewed
Feb 16, 2023
| @@ -427,8 +427,12 @@ impl LiteralDigitGrouping { | |||
|
|
|||
| let first = groups.next().expect("At least one group"); | |||
|
|
|||
| if (radix == Radix::Binary || radix == Radix::Hexadecimal) && groups.any(|i| i != 4 && i != 2) { | |||
| return Err(WarningType::UnusualByteGroupings); | |||
| if radix == Radix::Binary || radix == Radix::Octal || radix == Radix::Hexadecimal { | |||
There was a problem hiding this comment.
Suggested change
| if radix == Radix::Binary || radix == Radix::Octal || radix == Radix::Hexadecimal { | |
| if radix != Radix::Decimal { |
There was a problem hiding this comment.
I think this keeps the intention clearer.
|
r? @llogiq |
|
Thank you! @bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
This was referenced Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #6556
This lint required byte groupings of size 2 or 4 for
Radix::BinaryandRadix::Hexadecimal. Since there are good reasons for allowing groups of other sizes, this PR relaxes the restriction. This lint now requires thatchangelog: [
unusual_byte_groupings]: reduce false positives by relaxing restriction requiring groups of specific sizes.