Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not propose to simplify a not expression coming from a macro #10527

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

samueltardieu
Copy link
Contributor

Fixes #10523

changelog: FP [nonminimal_bool]: do not propose to change code coming from a macro

@rustbot
Copy link
Collaborator

rustbot commented Mar 22, 2023

r? @dswij

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Mar 22, 2023
@dswij
Copy link
Member

dswij commented Mar 22, 2023

LGTM, thanks for this! @bors r+

@bors
Copy link
Collaborator

bors commented Mar 22, 2023

📌 Commit b138bb5 has been approved by dswij

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Mar 22, 2023

⌛ Testing commit b138bb5 with merge 1d1e723...

@bors
Copy link
Collaborator

bors commented Mar 22, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: dswij
Pushing 1d1e723 to master...

1 similar comment
@bors
Copy link
Collaborator

bors commented Mar 22, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: dswij
Pushing 1d1e723 to master...

@bors bors merged commit 1d1e723 into rust-lang:master Mar 22, 2023
@samueltardieu samueltardieu deleted the issue-10523 branch March 24, 2023 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nonminimal_bool triggers on is_some() through macros
4 participants