Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix [mem_replace_option_with_none] not considering field variables #10594

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

J-ZhengLi
Copy link
Member

fixes: #9824


changelog: fix [mem_replace_option_with_none] not considering field variables

@rustbot
Copy link
Collaborator

rustbot commented Apr 4, 2023

r? @Jarcho

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 4, 2023
@Jarcho
Copy link
Contributor

Jarcho commented Apr 6, 2023

Looks good. Thank you. @bors r+

@bors
Copy link
Collaborator

bors commented Apr 6, 2023

📌 Commit 008e07d has been approved by Jarcho

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Apr 6, 2023

⌛ Testing commit 008e07d with merge de5c6d6...

@bors
Copy link
Collaborator

bors commented Apr 6, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Jarcho
Pushing de5c6d6 to master...

@bors bors merged commit de5c6d6 into rust-lang:master Apr 6, 2023
@J-ZhengLi J-ZhengLi deleted the issue9824 branch April 7, 2023 09:12
micolous added a commit to micolous/cec-rs that referenced this pull request Jun 23, 2023
ssalonen pushed a commit to ssalonen/cec-rs that referenced this pull request Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False negative on mem_replace_option_with_none
4 participants