Fix diverging_sub_expression not checking body of block
#10785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Jarcho (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
Jarcho
reviewed
May 18, 2023
|
☔ The latest upstream changes (presumably #10802) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Clippy has a no merge commit policy. You'll have to rebase your changes instead. |
Centri3
force-pushed
the
diverting_sub_expression
branch
from
5882252
to
0894a9d
Compare
Could've sworn I did that the first time, not sure what I did. I guess it's clear now I have no idea what I'm doing 😄 |
Jarcho
reviewed
Jun 8, 2023
Jarcho
reviewed
Jun 9, 2023
|
Feel free to squash after fixing the last little nit. |
Update mixed_read_write_in_expression.rs Update diverging_sub_expression.stderr
Centri3
force-pushed
the
diverting_sub_expression
branch
from
8ee9598
to
c1c134a
Compare
Jarcho
reviewed
Jun 9, 2023
|
Thank you. @bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10776
This also adds a warning to the test
ui/never_loop.rs, not sure if this is correct or not.changelog: [
diverging_sub_expression]: Fix false negatives with body of block