Improve pattern printing for manual_let_else #10797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @llogiq (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
|
cc @giraffate |
This was referenced May 18, 2023
* Replace variables inside | patterns in the if let: let v = if let V::A(v) | V::B(v) = v { v } else ...
* Support nested patterns: let v = if let Ok(Ok(Ok(v))) = v { v } else ...
* Support tuple structs with more than one arg: let v = V::W(v, _) = v { v } else ...
* Correctly handle .. in tuple struct patterns: let v = V::X(v, ..) = v { v } else ...
est31
force-pushed
the
manual_let_else_pattern
branch
from
d453520
to
ef38662
Compare
|
Great improvement! Thank you! @bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
bors
added a commit
that referenced
this pull request
Jun 3, 2023
manual_let_else: support struct patterns This adds upon the improvements of #10797 and: * Only prints `()` around `Or` patterns at the top level (fixing a regression of #10797) * Supports multi-binding patterns: `let (u, v) = if let (Some(u_i), Ok(v_i)) = ex { (u_i, v_i) } else ...` * Traverses through tuple patterns: `let v = if let (Some(v), None) = ex { v } else ...` * Supports struct patterns: `let v = if let S { v, w, } = ex { (v, w) } else ...` ``` changelog: [`manual_let_else`]: improve pattern printing to support struct patterns ``` fixes #10708 fixes #10424
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
let v = if let V::A(v) | V::B(v) = v { v } else ...let v = if let Ok(Ok(Ok(v))) = v { v } else ...let v = V::W(v, _) = v { v } else ...; note that more than one capture is still not supported, so it bails forlet (v, w) = if let E::F(vi, wi) = x { (vi, wi)}let v = V::X(v, ..) = v { v } else ....stderrfile)cargo testpasses locallycargo dev update_lintscargo dev fmtchangelog: [
manual_let_else]: improve variable name in suggestionsCloses #10431 as this PR is adding a test for the
mutcase.