Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds new lint arc_with_non_send_or_sync #10898

Merged
merged 4 commits into from
Jun 8, 2023
Merged

Conversation

avborhanian
Copy link
Contributor

Fixes #653

Adds a new lint to check for uses of non-Send/Sync types within Arc.

changelog: [`arc_with_non_send_sync`]: Added a lint to detect uses of non-Send/Sync types within Arc.

@rustbot
Copy link
Collaborator

rustbot commented Jun 6, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Alexendoo (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 6, 2023
@Manishearth
Copy link
Member

@Centri3 may also review this

Copy link
Member

@Centri3 Centri3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good! Couple nits for the docs and suggestion.

clippy_lints/src/arc_with_non_send_sync.rs Outdated Show resolved Hide resolved
clippy_lints/src/arc_with_non_send_sync.rs Outdated Show resolved Hide resolved
clippy_lints/src/arc_with_non_send_sync.rs Outdated Show resolved Hide resolved
clippy_lints/src/arc_with_non_send_sync.rs Outdated Show resolved Hide resolved
@Manishearth
Copy link
Member

@bors r=Manishearth,Centri3

@bors
Copy link
Collaborator

bors commented Jun 8, 2023

📌 Commit 20548eb has been approved by Manishearth,Centri3

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jun 8, 2023

⌛ Testing commit 20548eb with merge 60258b0...

@bors
Copy link
Collaborator

bors commented Jun 8, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Manishearth,Centri3
Pushing 60258b0 to master...

@bors bors merged commit 60258b0 into rust-lang:master Jun 8, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lint Arc<_> within non Send/Sync type
6 participants