New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new lint null_pointer_optimization
#10960
Conversation
r? @Alexendoo (rustbot has picked a reviewer for you, use r? to override) |
778fcee
to
55c3023
Compare
☔ The latest upstream changes (presumably #10951) made this pull request unmergeable. Please resolve the merge conflicts. |
55c3023
to
f4abdab
Compare
Sometimes you do need a |
IIUC, |
f4abdab
to
cf628b1
Compare
So technically yeah you can move the |
We could probably add an additional check for Description should probably be updated (again!) to mention |
cf628b1
to
9dbcf93
Compare
☔ The latest upstream changes (presumably #11316) made this pull request unmergeable. Please resolve the merge conflicts. |
Hey this is triage, I'm closing this due to inactivity. Currently, @Centri3 sadly doesn't have the time to continue this implementation. If anyone is interested in continuing this PR, you're more than welcome to create a new PR and push it over the finish line. :D Thank you to @Centri3 and the reviewers for the time, that you already put into this! @rustbot label +S-inactive-closed -S-waiting-on-author -S-waiting-on-review |
Although this doesn't close #9983, I think this is good enough and is more general than such a change to
large_enum_variant
:)changelog: New lint [
null_pointer_optimization
]