Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New lints ['needless_pub_self], [pub_with_shorthand] and [pub_without_shorthand] #10967

Merged
merged 2 commits into from Jun 28, 2023
Merged

New lints ['needless_pub_self], [pub_with_shorthand] and [pub_without_shorthand] #10967

merged 2 commits into from Jun 28, 2023

Conversation

Centri3
Copy link
Member

@Centri3 Centri3 commented Jun 16, 2023

Closes #10963
Closes #10964

changelog: New lints ['needless_pub_self], [pub_with_shorthand] and [pub_without_shorthand]

@rustbot
Copy link
Collaborator

rustbot commented Jun 16, 2023

r? @Manishearth

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 16, 2023
@bors
Copy link
Collaborator

bors commented Jun 19, 2023

☔ The latest upstream changes (presumably #10951) made this pull request unmergeable. Please resolve the merge conflicts.

Manishearth
Manishearth approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@Manishearth Manishearth left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code r=me, unsure on lint category

opened a zulip discussion

@Centri3 Centri3 force-pushed the visibility_lints2 branch 2 times, most recently from 8e71927 to 0d4c163 Compare June 27, 2023 10:29
@Centri3
Copy link
Member Author

Centri3 commented Jun 27, 2023

I've changed the category to style and rebased (with a minor hiccup due to merging accidentally 😅)

@bors
Copy link
Collaborator

bors commented Jun 27, 2023

☔ The latest upstream changes (presumably #10884) made this pull request unmergeable. Please resolve the merge conflicts.

@Manishearth
Copy link
Member

still has conflicts apparently

@Centri3
Copy link
Member Author

Centri3 commented Jun 28, 2023

Huh odd, looks like it was manual_range_patterns but bors didn't give the comment for some reason

@Manishearth
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 28, 2023

📌 Commit 46aa8ab has been approved by Manishearth

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jun 28, 2023

⌛ Testing commit 46aa8ab with merge 36f4feb...

@bors
Copy link
Collaborator

bors commented Jun 28, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Manishearth
Pushing 36f4feb to master...

@bors bors merged commit 36f4feb into rust-lang:master Jun 28, 2023
8 checks passed
@LikeLakers2
Copy link

If I may ask, when will these be available on stable? Presumably when the next version of Rust comes out? Or something else?

@Centri3 Centri3 deleted the visibility_lints2 branch June 28, 2023 10:37
@Centri3
Copy link
Member Author

Centri3 commented Jun 28, 2023

For nightly, when the next sync happens - it's been blocked for a good bit though. I believe 1.72.0 for the next rust version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LikeLakers2 LikeLakers2 LikeLakers2 left review comments

@Manishearth Manishearth Manishearth approved these changes

Assignees

@Manishearth Manishearth

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lint to remove instances of pub(self) and pub(in self) Lints to enforce either pub(<loc>) or pub(in <loc>)
5 participants
@Centri3 @rustbot @bors @Manishearth @LikeLakers2