Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow safety comment above attributes #10986

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

Centri3
Copy link
Member

@Centri3 Centri3 commented Jun 18, 2023

Closes #8679

changelog: Enhancement: [undocumented_safety_block]: Added accept-comment-above-attributes configuration.

@rustbot
Copy link
Collaborator

rustbot commented Jun 18, 2023

r? @Manishearth

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 18, 2023
Copy link
Member

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally ok with it being on by default but don't mind it being off too

@Manishearth
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 20, 2023

📌 Commit 9891e47 has been approved by Manishearth

It is now in the queue for this repository.

bors added a commit that referenced this pull request Jun 20, 2023
Allow safety comment above attributes

Closes #8679

changelog: Enhancement: [`undocumented_safety_block`]: Added `accept-comment-above-attributes` configuration.
@bors
Copy link
Collaborator

bors commented Jun 20, 2023

⌛ Testing commit 9891e47 with merge 2bc671b...

@bors
Copy link
Collaborator

bors commented Jun 20, 2023

💔 Test failed - checks-action_test

@Centri3 Centri3 force-pushed the undocumented_unsafe_blocks branch from 9891e47 to cc2e49f Compare June 20, 2023 04:47
@Centri3
Copy link
Member Author

Centri3 commented Jun 20, 2023

Ok that one was my fault 😅

@Manishearth

@Manishearth
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 20, 2023

📌 Commit cc2e49f has been approved by Manishearth

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jun 20, 2023

⌛ Testing commit cc2e49f with merge 8fd021f...

@bors
Copy link
Collaborator

bors commented Jun 20, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Manishearth
Pushing 8fd021f to master...

@bors bors merged commit 8fd021f into rust-lang:master Jun 20, 2023
8 checks passed
@Centri3 Centri3 deleted the undocumented_unsafe_blocks branch June 20, 2023 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

#[allow(unsafe_code)] should be allowed after SAFETY: docs
4 participants