new lint: type_id_on_box
#10987
Merged
new lint: type_id_on_box
#10987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @llogiq (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
llogiq
reviewed
Jun 18, 2023
|
|
||
| #![warn(clippy::type_id_on_box)] | ||
|
|
||
| use std::any::{Any, TypeId}; |
There was a problem hiding this comment.
I'd like to see a test where the type is behind a type alias, just to be sure we are privy to possible interactions.
There was a problem hiding this comment.
I added a few more tests. Not sure if this is how you meant it though
Nilstrieb
reviewed
Jun 20, 2023
| use rustc_middle::ty::{self, ExistentialPredicate}; | ||
| use rustc_span::{sym, Span}; | ||
|
|
||
| fn is_dyn_trait(cx: &LateContext<'_>, ty: Ty<'_>) -> bool { |
There was a problem hiding this comment.
Suggested change
| fn is_dyn_trait(cx: &LateContext<'_>, ty: Ty<'_>) -> bool { | |
| fn is_dyn_any(cx: &LateContext<'_>, ty: Ty<'_>) -> bool { |
|
Thank you! @bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7687.
A new lint that detects calling
.type_id()onBox<dyn Any>(and not on the underlyingdyn Any), which can make up for some pretty confusing bugs!changelog: new lint: [
type_id_on_box]