New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lint mem_forget
if any fields are Drop
#10996
Conversation
r? @xFrednet (rustbot has picked a reviewer for you, use r? to override) |
Would probably be worth moving this next to rust-clippy/clippy_lints/src/drop_forget_ref.rs Lines 126 to 128 in b3ae038
|
Super swift as always. Thank you! King bors, would you please accept this beautiful change into the marvelous kingdom of Master Branch Land? |
💔 Test failed - checks-action_remark_test |
Looks like npm has some problems fetching the remark thingy. Let's try again? @bors retry |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
1 similar comment
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Closes #9298
I think this way of doing it (
needs_drop
) should be fine.changelog: Enhancement: [
mem_forget
]: Now lints on types with fields that implementDrop
#10996