Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid linting extra_unused_type_parameters on procedural macros #11022

Merged
merged 1 commit into from Jun 25, 2023

Conversation

lochetti
Copy link
Contributor

@lochetti lochetti commented Jun 24, 2023

Don't lint extra_unused_type_parameters if code was generated by procedural macro.

This PR fixes #11014

changelog: [extra_unused_type_parameters] avoid linting macro-generated code

@rustbot
Copy link
Collaborator

rustbot commented Jun 24, 2023

r? @dswij

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 24, 2023
Copy link
Member

@dswij dswij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@dswij
Copy link
Member

dswij commented Jun 25, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 25, 2023

📌 Commit f0eb40c has been approved by dswij

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jun 25, 2023

⌛ Testing commit f0eb40c with merge a30ca62...

@bors
Copy link
Collaborator

bors commented Jun 25, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: dswij
Pushing a30ca62 to master...

@bors bors merged commit a30ca62 into rust-lang:master Jun 25, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False-positive extra_unused_type_parameters
4 participants