Skip if_not_else lint for '!= 0'-style checks #11028
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, clippy makes unhelpful suggestions such as this:
Bit tests often take on the form
if foo & 0x1234 != 0 { … } else { … }
, and the!= 0
part reads as "has any bits set". Therefore, this code already has the "correct" order, and shouldn't be changed.This PR disables the lint for these cases, and in fact all cases where the condition is "foo is non-zero".
I did my homework:
.stderr
file) → Yes,tests/ui/if_not_else_bittest.rs
cargo test
passes locallycargo dev update_lints
cargo dev fmt
changelog: Fix [
if_not_else
] false positive when something likebitflags != 0
is used