Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

suggests is_some_and over map().unwrap #11030

Merged
merged 8 commits into from
Jun 29, 2023
Merged

suggests is_some_and over map().unwrap #11030

merged 8 commits into from
Jun 29, 2023

Commits on Jun 27, 2023

  1. suggests is_some_and over map().unwrap_or(false)

    @darklyspaced
    darklyspaced committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    9b7d8d1 View commit details
    Browse the repository at this point in the history

  2. changed the msrv to 1.70 to suggest is_some_and 

    if the msrv is not >= 1.70 then the `map_or` is suggested instead of `is_some_and` (even when `unwrap_or` returns false)
    @darklyspaced
    darklyspaced committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    c60222d View commit details
    Browse the repository at this point in the history

  3. now passes dogfood by wrapping unwrap_recv and unwrap_arg into a tuple 

    was previously failing due to `check` having to many arguments.
    @darklyspaced
    darklyspaced committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    b832175 View commit details
    Browse the repository at this point in the history

  4. Revert "now passes dogfood by wrapping unwrap_recv and unwrap_arg int… 

    …o a tuple"

This reverts commit 7b91844.
    @darklyspaced
    darklyspaced committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    c378bf9 View commit details
    Browse the repository at this point in the history

  5. ignore too_many_arguments on check

    @darklyspaced
    darklyspaced committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    ca00b13 View commit details
    Browse the repository at this point in the history

  6. changed msrv name for consistency & changed nested if for style

    @darklyspaced
    darklyspaced committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    a693cbc View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2023

  1. updated list of lints that use msrv

    @darklyspaced
    darklyspaced committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    211278b View commit details
    Browse the repository at this point in the history

  2. ran cargo collect-metadata

    @darklyspaced
    darklyspaced committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    bb42b18 View commit details
    Browse the repository at this point in the history