Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[panic_in_result_fn] remove todo!, unimplemented!, unreachable! #11123

Merged
merged 1 commit into from
Jul 13, 2023
Merged

[panic_in_result_fn] remove todo!, unimplemented!, unreachable! #11123

merged 1 commit into from
Jul 13, 2023

Conversation

panosfol
Copy link
Contributor

@panosfol panosfol commented Jul 7, 2023

This commit fixes #11025 by removing checks for todo!, unimplemented! and unreachable!.

changelog: [panic_in_result_fn] remove todo!, unimplemented!, unreachable!

@rustbot
Copy link
Collaborator

rustbot commented Jul 7, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @giraffate (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 7, 2023
giraffate
giraffate reviewed Jul 11, 2023
View reviewed changes
Copy link
Contributor

@giraffate giraffate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we leave these tests as they are without removing them?

@panosfol
[panic_in_result_fn] remove todo!, unimplemented!, unreachable!
c49c177 
This commit fixes rust-lang#11025 by removing checks for `todo!`,
`unimplemented!` and `unreachable!`.

Signed-off-by: Panagiotis Foliadis <pfoliadis@hotmail.com>
@panosfol
Copy link
Contributor Author

Can we leave these tests as they are without removing them?

@giraffate I restored the tests, but may I ask why do we keep them unchanged?

@giraffate
Copy link
Contributor

I restored the tests, but may I ask why do we keep them unchanged?

I want to check that this lint doesn't warn the tests by this change.

@giraffate
Copy link
Contributor

@bors r+

Thanks!

@bors
Copy link
Collaborator

bors commented Jul 12, 2023

📌 Commit c49c177 has been approved by giraffate

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jul 12, 2023

⌛ Testing commit c49c177 with merge df92b52...

@bors
Copy link
Collaborator

bors commented Jul 13, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: giraffate
Pushing df92b52 to master...

@bors bors merged commit df92b52 into rust-lang:master Jul 13, 2023
5 checks passed
This was referenced Oct 5, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giraffate giraffate giraffate left review comments

Assignees

@giraffate giraffate

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

panic_in_result_fn shouldn't fire on todo!()/unimplemented!()/unreachable!()
4 participants
@panosfol @rustbot @giraffate @bors