Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ICE in #10535 #11130

Merged
merged 2 commits into from
Jul 9, 2023
Merged

Fix ICE in #10535 #11130

merged 2 commits into from
Jul 9, 2023

Conversation

smoelius
Copy link
Contributor

@smoelius smoelius commented Jul 8, 2023

Fixes #10535

r? @Jarcho

changelog: Eliminate ICE described in #10535

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 8, 2023
@Jarcho
Copy link
Contributor

Jarcho commented Jul 9, 2023

Thank you. @bors r+

@bors
Copy link
Collaborator

bors commented Jul 9, 2023

📌 Commit 3bf2138 has been approved by Jarcho

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jul 9, 2023

⌛ Testing commit 3bf2138 with merge 757fe49...

@bors
Copy link
Collaborator

bors commented Jul 9, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Jarcho
Pushing 757fe49 to master...

@bors bors merged commit 757fe49 into rust-lang:master Jul 9, 2023
5 checks passed
@Jarcho Jarcho added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jul 9, 2023
@smoelius smoelius deleted the fix-10535 branch July 9, 2023 01:10
@flip1995 flip1995 added beta-accepted Accepted for backporting to the compiler in the beta channel. and removed beta-nominated Nominated for backporting to the compiler in the beta channel. labels Aug 17, 2023
@flip1995
Copy link
Member

rust-lang/rust#114937

bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 17, 2023
…k-Simulacrum

[beta] Clippy backports for ICE fixes

This backports PRs to beta, that fix ICEs, some lint grouping and FP fixes. Namely:

- rust-lang/rust-clippy#11191
- rust-lang/rust-clippy#11172
- rust-lang/rust-clippy#11130
- rust-lang/rust-clippy#11106
- rust-lang/rust-clippy#11104
- rust-lang/rust-clippy#11077
- rust-lang/rust-clippy#11070 (This PR is not synced to the Rust repo yet, but I will open a separate PR to get it into `master`, before beta is branched: rust-lang#114938)
- rust-lang/rust-clippy#11069

Kind of a big backport, but most of it is tests.

r? `@Mark-Simulacrum`

cc `@Manishearth`
@xFrednet xFrednet removed the beta-accepted Accepted for backporting to the compiler in the beta channel. label Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE: do not use optimized_mir for constants: Static(Not)
6 participants