Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[significant_drop_tightening] Fix #11160 #11161

Merged
merged 1 commit into from Jul 20, 2023
Merged

[significant_drop_tightening] Fix #11160 #11161

merged 1 commit into from Jul 20, 2023

Conversation

c410-f3r
Copy link
Contributor

@c410-f3r c410-f3r commented Jul 14, 2023 •
edited by dswij

Fix #11160

changelog: [significant_drop_tightening]: Ignore literals in function returns

@rustbot
Copy link
Collaborator

rustbot commented Jul 14, 2023

r? @dswij

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 14, 2023
dswij
dswij approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@dswij dswij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Thanks for this!

@dswij
Copy link
Member

dswij commented Jul 20, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 20, 2023

📌 Commit 1f82f6d has been approved by dswij

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jul 20, 2023

⌛ Testing commit 1f82f6d with merge d764a0e...

@bors
Copy link
Collaborator

bors commented Jul 20, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: dswij
Pushing d764a0e to master...

@bors bors merged commit d764a0e into rust-lang:master Jul 20, 2023
5 checks passed
@bors bors mentioned this pull request Jul 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dswij dswij dswij approved these changes

Assignees

@dswij dswij

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[significant_drop_tightening] Functions that return literals should not trigger the lint
4 participants
@c410-f3r @rustbot @dswij @bors