Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove #![allow(unused)] and --crate-name from cargo dev new_lint generated tests #11183

Merged
merged 2 commits into from Jul 19, 2023

Conversation

Alexendoo
Copy link
Member

changelog: none

Also removes some unused flags from ui-cargo tests because the entrypoint is now the Cargo.toml, not the .rs files

@rustbot
Copy link
Collaborator

rustbot commented Jul 18, 2023

r? @xFrednet

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 18, 2023
@xFrednet
Copy link
Member

Looks good to me, thanks!

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 19, 2023

📌 Commit f539e1a has been approved by xFrednet

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jul 19, 2023

⌛ Testing commit f539e1a with merge 0fa1fd3...

@bors
Copy link
Collaborator

bors commented Jul 19, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing 0fa1fd3 to master...

@bors bors merged commit 0fa1fd3 into rust-lang:master Jul 19, 2023
5 checks passed
@Alexendoo Alexendoo deleted the new-lint-template branch July 19, 2023 11:12
@Alexendoo
Copy link
Member Author

Realised I didn't mention why #![allow(unused)] was removed so for posterity: we pass -A unused to tests in compile-test.rs but the old compiletest-rs crate didn't apply that when running .fixed files, ui_test does so it's no longer needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants