Fix async functions handling for needless_pass_by_ref_mut lint
#11184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
GuillaumeGomez
force-pushed
the
needless_pass_by_ref_mut-async
branch
from
cc136a0
to
2bd296f
Compare
GuillaumeGomez
force-pushed
the
needless_pass_by_ref_mut-async
branch
from
2bd296f
to
5e9e462
Compare
|
Fixed the failing lints on my code changes. ^^' |
|
Thank you! @bors r+ |
bors
added a commit
that referenced
this pull request
Jul 22, 2023
… r=llogiq Fix async functions handling for `needless_pass_by_ref_mut` lint Fixes #11179. The problem with async is that "internals" are actually inside a closure from the `ExprUseVisitor` point of view, meaning we need to actually run the check on the closures' body as well. r? `@llogiq`
|
💔 Test failed - checks-action_test |
|
It failed because of the commit format. I added |
|
@bors retry |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
This was referenced Jul 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11179.
The problem with async is that "internals" are actually inside a closure from the
ExprUseVisitorpoint of view, meaning we need to actually run the check on the closures' body as well.changelog: none
r? @llogiq