Misc fixes #11186
Misc fixes #11186
Conversation
|
r? @dswij (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
|
Oh right, I cleaned up tests which didn't allow |
Centri3
force-pushed
the
misc
branch
3 times, most recently
from
9906122
to
dd50194
Compare
|
☔ The latest upstream changes (presumably #11207) made this pull request unmergeable. Please resolve the merge conflicts. |
|
☔ The latest upstream changes (presumably #11198) made this pull request unmergeable. Please resolve the merge conflicts. |
| #[allow(clippy::single_call_fn)] | ||
| fn lint_attr_test() {} | ||
|
|
||
| fn lint_attr_test_caller() { | ||
| lint_attr_test(); | ||
| } |
There was a problem hiding this comment.
Lint attributes, allowing it on the function wouldn't do anything (I think). Similarly with warn and others
| | | ||
| LL | let _ = future; | ||
| | ^^^^^^^^^^^^^^^ | ||
| | | ||
| = help: consider awaiting the future or dropping explicitly with `std::mem::drop` | ||
|
|
||
| error: this argument is a mutable reference, but not used mutably |
There was a problem hiding this comment.
Wonder if we can have a CI test to prevent this stuff from happening 🤔
There was a problem hiding this comment.
We can probably search for -D followed by anything that isn't a specific lint. Not sure how you'd set that "specific lint" for each test though
|
☔ The latest upstream changes (presumably #11269) made this pull request unmergeable. Please resolve the merge conflicts. |
+ other misc changes.
Also moves `tuple_array_conversions` to `pedantic`, because rust-lang#11171 didn't contain it fsr
|
☔ The latest upstream changes (presumably #11239) made this pull request unmergeable. Please resolve the merge conflicts. |
| @@ -37,7 +37,7 @@ declare_clippy_lint! { | |||
| /// ``` | |||
| #[clippy::version = "1.72.0"] | |||
| pub TUPLE_ARRAY_CONVERSIONS, | |||
| nursery, | |||
| pedantic, | |||
There was a problem hiding this comment.
Are we sure we want to move this to pedantic?
|
Hey this is triage, I'm closing this due to inactivity. Currently, @Centri3 sadly doesn't have the time to continue this implementation. If anyone is interested in continuing this PR, you're more than welcome to create a new PR and push it over the finish line. :D Thank you to @Centri3 and the reviewers for the time, that you already put into this! @rustbot label +S-inactive-closed -S-waiting-on-author -S-waiting-on-review |
rustbot
added
S-inactive-closed
Fixes a typo in
needless_pass_by_ref_mut's description and changes its msg a bit.Also,
single_call_fnnow takes into account lint attrs, which it didn't beforechangelog: [
single_call_fn]: Now takes into account lint attributes on the function's signature (e.g.,#[allow(...)])