new lint: [should_panic_without_expect]

[y21]

Closes #10956

changelog: new lint: [should_panic_without_expect]

[rustbot]

r? @Alexendoo

(rustbot has picked a reviewer for you, use r? to override)

[Alexendoo]

I'd say call this should_panic_without_expect, I wasn't aware you could supply an expected panic message and the title made me think it would be like a comment

[y21]

I'd say call this should_panic_without_expect, I wasn't aware you could supply an expected panic message and the title made me think it would be like a comment

Good point, I renamed the lint and also rewrote it as a late lint now

[y21]

I'm not sure why CI is failing. It wants me to run cargo uibless but that does nothing. Afaict it failed on cargo test --features deny-warnings,internal but if I run it locally it passes 😕

[Centri3]

Maybe rebase and run cargo bless? rustfix is ran automatically now so it may be creating a fixed file

[Alexendoo]

You can add //@no-rustfix to prevent that

[Alexendoo]

👍

@bors r+

[bors]

📌 Commit b4ab67f has been approved by Alexendoo

It is now in the queue for this repository.

[bors]

⌛ Testing commit b4ab67f with merge b7cad50...

[bors]

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Alexendoo
Pushing b7cad50 to master...