Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[blocked] attempt to check rust-lang/rust with clippy in ci #11235

Draft
wants to merge 34 commits into
base: master
Choose a base branch
from

Conversation

matthiaskrgr
Copy link
Member

@matthiaskrgr matthiaskrgr commented Jul 26, 2023

r? @ghost

changelog: run clippy on rust-lang/rust as integration test

This might be blocked on at least
#11230
#11176
#11256

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 26, 2023
@matthiaskrgr matthiaskrgr marked this pull request as draft July 26, 2023 16:59
@matthiaskrgr matthiaskrgr changed the title attempt to run check rust-lang/rust with clippy in ci attempt to check rust-lang/rust with clippy in ci Jul 26, 2023
@matthiaskrgr
Copy link
Member Author

@bors try

@bors
Copy link
Collaborator

bors commented Jul 26, 2023

⌛ Trying commit a1292be with merge d6936d8...

bors added a commit that referenced this pull request Jul 26, 2023
attempt to check rust-lang/rust with clippy in ci

r? `@ghost`

changelog: run clippy on rust-lang/rust as integration test
@matthiaskrgr
Copy link
Member Author

@bors try

@bors
Copy link
Collaborator

bors commented Jul 26, 2023

⌛ Trying commit 0a79d65 with merge b1f86f2...

bors added a commit that referenced this pull request Jul 26, 2023
attempt to check rust-lang/rust with clippy in ci

r? `@ghost`

changelog: run clippy on rust-lang/rust as integration test
@bors
Copy link
Collaborator

bors commented Jul 26, 2023

💔 Test failed - checks-action_test

@matthiaskrgr
Copy link
Member Author

@bors try

@bors
Copy link
Collaborator

bors commented Jul 26, 2023

⌛ Trying commit 5d592ce with merge 16398c3...

bors added a commit that referenced this pull request Jul 26, 2023
attempt to check rust-lang/rust with clippy in ci

r? `@ghost`

changelog: run clippy on rust-lang/rust as integration test
@matthiaskrgr
Copy link
Member Author

@bors try

@bors
Copy link
Collaborator

bors commented Jul 26, 2023

⌛ Trying commit 5d592ce with merge 5021d35...

bors added a commit that referenced this pull request Jul 26, 2023
attempt to check rust-lang/rust with clippy in ci

r? `@ghost`

changelog: run clippy on rust-lang/rust as integration test
@matthiaskrgr
Copy link
Member Author

wut that is outdated
@bors try

bors added a commit that referenced this pull request Jul 26, 2023
attempt to check rust-lang/rust with clippy in ci

r? `@ghost`

changelog: run clippy on rust-lang/rust as integration test
@matthiaskrgr
Copy link
Member Author

@bors try

@bors
Copy link
Collaborator

bors commented Jul 26, 2023

⌛ Trying commit fb39403 with merge 2d722f6...

bors added a commit that referenced this pull request Jul 26, 2023
attempt to check rust-lang/rust with clippy in ci

r? `@ghost`

changelog: run clippy on rust-lang/rust as integration test
@matthiaskrgr
Copy link
Member Author

@bors try

@bors
Copy link
Collaborator

bors commented Jul 26, 2023

⌛ Trying commit 1818903 with merge 70894c3...

bors added a commit that referenced this pull request Jul 26, 2023
attempt to check rust-lang/rust with clippy in ci

r? `@ghost`

changelog: run clippy on rust-lang/rust as integration test
@bors
Copy link
Collaborator

bors commented Jul 26, 2023

💔 Test failed - checks-action_test

@matthiaskrgr
Copy link
Member Author

@bors try

@bors
Copy link
Collaborator

bors commented Sep 27, 2023

⌛ Trying commit d8f5a04 with merge b7ce2bf...

bors added a commit that referenced this pull request Sep 27, 2023
[blocked] attempt to check rust-lang/rust with clippy in ci

r? `@ghost`

changelog: run clippy on rust-lang/rust as integration test

This might be blocked on at least
#11230
#11176
#11256
@bors
Copy link
Collaborator

bors commented Sep 27, 2023

💔 Test failed - checks-action_test

@bors
Copy link
Collaborator

bors commented Dec 5, 2023

☔ The latest upstream changes (presumably #11929) made this pull request unmergeable. Please resolve the merge conflicts.

@xFrednet
Copy link
Member

Hey @matthiaskrgr, this is a ping from triage. Are you still working on this PR?

@matthiaskrgr
Copy link
Member Author

I thiiink we can sunset it since there have been a lot of improvements in rustc including running clippy in ci there.

unless someone else feels strongly and definitely wants this here?

@xFrednet
Copy link
Member

I'm fine with how it is, but this is something @flip1995 might have some thoughts on since he does the syncs.

Otherwise we can close this PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants