Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't pass extra generic arguments in needless_borrow #11259

Merged
merged 1 commit into from Sep 4, 2023

Conversation

Jarcho
Copy link
Contributor

@Jarcho Jarcho commented Jul 30, 2023

fixes #10253

Also switches to using implements_trait which does ICE when clippy's debug assertions are enabled.

changelog: None

@rustbot
Copy link
Collaborator

rustbot commented Jul 30, 2023

r? @dswij

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 30, 2023
Copy link
Member

@dswij dswij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@dswij
Copy link
Member

dswij commented Sep 4, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 4, 2023

📌 Commit 8277e7d has been approved by dswij

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Sep 4, 2023

⌛ Testing commit 8277e7d with merge f13e1f4...

@bors
Copy link
Collaborator

bors commented Sep 4, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: dswij
Pushing f13e1f4 to master...

@bors bors merged commit f13e1f4 into rust-lang:master Sep 4, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE checking rustc_middle with debug_assertions enabled
4 participants