Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[filter_map_bool_then]: Don't ICE on late bound regions #11318

Merged
merged 2 commits into from Aug 11, 2023

Conversation

Centri3
Copy link
Member

@Centri3 Centri3 commented Aug 10, 2023

Fixes #11309

Also lints &NonCopy now, since any & is Copy. That was accidental, but it seems that this is a consequence (or improvement!) of this fix.

r? @Jarcho

changelog: [filter_map_bool_then]: Don't ICE on late bound regions

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 10, 2023
@Centri3
Copy link
Member Author

Centri3 commented Aug 10, 2023

Also lints &NonCopy now, since any & is Copy. That was accidental, but it seems that this is a consequence (or improvement!) of this fix.

Oh this is because it no longer calls peel_refs, though I suppose this works fine

@Manishearth
Copy link
Member

@bors r+

this might complicate the next sync given the revert, let's see how this goes.

@bors
Copy link
Collaborator

bors commented Aug 11, 2023

📌 Commit 7b2fd81 has been approved by Manishearth

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Aug 11, 2023

⌛ Testing commit 7b2fd81 with merge bd1554c...

@bors
Copy link
Collaborator

bors commented Aug 11, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Manishearth
Pushing bd1554c to master...

@bors bors merged commit bd1554c into rust-lang:master Aug 11, 2023
5 checks passed
@bors bors mentioned this pull request Aug 11, 2023
@Centri3 Centri3 deleted the #11309 branch August 11, 2023 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE: has escaping bound vars, so it cannot be wrapped in a dummy binder in is_copy_raw
6 participants