Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix "derivable_impls: attributes are ignored" #11404

Merged
merged 1 commit into from Aug 26, 2023

Conversation

kiscad
Copy link
Contributor

@kiscad kiscad commented Aug 25, 2023

Please write a short comment explaining your change (or "none" for internal only changes)

changelog: [derivable_impls]: allow the lint when the trait-impl methods has any attribute.

fixes #11368

@rustbot
Copy link
Collaborator

rustbot commented Aug 25, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 25, 2023
@kiscad
Copy link
Contributor Author

kiscad commented Aug 25, 2023

r? @matthiaskrgr

@rustbot rustbot assigned matthiaskrgr and unassigned Manishearth Aug 25, 2023
@matthiaskrgr
Copy link
Member

@bors r+
thanks

@bors
Copy link
Collaborator

bors commented Aug 26, 2023

📌 Commit 90fcc67 has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Aug 26, 2023

⌛ Testing commit 90fcc67 with merge 4736908...

@bors
Copy link
Collaborator

bors commented Aug 26, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: matthiaskrgr
Pushing 4736908 to master...

1 similar comment
@bors
Copy link
Collaborator

bors commented Aug 26, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: matthiaskrgr
Pushing 4736908 to master...

@bors bors merged commit 4736908 into rust-lang:master Aug 26, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FP derivable_impls: attributes are ignored
5 participants