Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly format vec! invocations #11430

Merged
merged 2 commits into from Sep 1, 2023
Merged

Correctly format vec! invocations #11430

merged 2 commits into from Sep 1, 2023

Conversation

TDecking
Copy link
Contributor

@TDecking TDecking commented Aug 30, 2023

The Rust Style Guide says that vec! should alwys be used with square brackets, not parenthesis. Within the lint documentation, that rule was violated twice.

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Aug 30, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @giraffate (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 30, 2023
@giraffate
Copy link
Contributor

@bors r+

Thanks!

@bors
Copy link
Collaborator

bors commented Sep 1, 2023

📌 Commit 1f8b204 has been approved by giraffate

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Sep 1, 2023

⌛ Testing commit 1f8b204 with merge c1f8ae3...

@bors
Copy link
Collaborator

bors commented Sep 1, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: giraffate
Pushing c1f8ae3 to master...

@bors bors merged commit c1f8ae3 into rust-lang:master Sep 1, 2023
5 checks passed
@TDecking TDecking deleted the vec-fmt branch September 1, 2023 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants