[len_without_is_empty
]: follow type alias to find inherent is_empty
method
#11452
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11165
When we see an
impl B
andB
is a type alias to some typeA
, then we need to follow the type alias to look for anis_empty
method on the aliased typeA
. Before this PR, it'd get the inherent impls ofB
, which there aren't any and so it would warn that there isn't anis_empty
method even if there was one.Passing the type alias
DefId
toTyCtxt::type_of
gives us the aliasedDefId
(or simply return the type itself if it wasn't a type alias) so we can just use thatchangelog: [
len_without_is_empty
]: follow type alias to find inherentis_empty
method