New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
skip todo!()
in never_loop
#11455
skip todo!()
in never_loop
#11455
Conversation
r? @dswij (rustbot has picked a reviewer for you, use r? to override) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should only skip todo!
imo. unimplemented!
is used for stuff that won't be implemented, not for WIP code.
todo
/ unimplemented
in never_loop
todo!()
in never_loop
This version LGTM. r=me once |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small comment suggestion
r? Centri3 |
Thank you. @bors r=Centri3,dswij |
skip `todo!()` in `never_loop` As promised in #11450, here is an implementation which skips occurrences of the `todo!()` macro.
💔 Test failed - checks-action_test |
how do I kick the bot to try again? |
@bors retry The changelog line needs to start with |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
As promised in #11450, here is an implementation which skips occurrences of the
todo!()
macro.changelog: [
never_loop
]: skip loops containingtodo!()