Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix FP of let_unit_value on async fn args #11509

Merged
merged 2 commits into from Sep 16, 2023
Merged

Conversation

kiscad
Copy link
Contributor

@kiscad kiscad commented Sep 15, 2023

changelog: [let_unit_value]: fix the FalsePostive on async fn arguments

fix #11502

@rustbot
Copy link
Collaborator

rustbot commented Sep 15, 2023

r? @llogiq

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 15, 2023
@samueltardieu
Copy link
Contributor

No test?

@llogiq
Copy link
Contributor

llogiq commented Sep 16, 2023

Ok, this looks good to go. Thank you for making clippy better!

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 16, 2023

📌 Commit 7426c83 has been approved by llogiq

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Sep 16, 2023

⌛ Testing commit 7426c83 with merge f54275f...

@bors
Copy link
Collaborator

bors commented Sep 16, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing f54275f to master...

@bors bors merged commit f54275f into rust-lang:master Sep 16, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

false positive of let_unit_value on async fn arguments
5 participants