fix FP with needless_raw_string_hashes #11518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Alexendoo (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
J-ZhengLi
reviewed
Sep 21, 2023
| @@ -96,8 +96,9 @@ impl EarlyLintPass for RawStrings { | |||
| ); | |||
| }, | |||
| ); | |||
|
|
|||
| return; | |||
| if !matches!(cx.get_lint_level(NEEDLESS_RAW_STRINGS), rustc_lint::Allow) { | |||
There was a problem hiding this comment.
a small style nit: There's a clippy wrapper called is_lint_allowed, it should work here with the expr's HirId, I think.
There was a problem hiding this comment.
It looks that is_lint_allowed need a LateContext argument, but we have only EarlyContext here.
Alexendoo
approved these changes
Sep 21, 2023
|
Thanks! @bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
tamird
added a commit
to aya-rs/aya
that referenced
this pull request
Sep 27, 2023
```
warning: unnecessary hashes around raw string literal
--> xtask/src/docs.rs:70:17
|
70 | indoc! {r#"
| _________________^
71 | | User-Agent:*
72 | | Disallow: /
73 | | "#},
| |______^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_raw_string_hashes
= note: `#[warn(clippy::needless_raw_string_hashes)]` on by default
help: remove all the hashes around the literal
|
70 ~ indoc! {r"
71 | User-Agent:*
72 | Disallow: /
73 ~ "},
|
```
This false negative was fixed in
rust-lang/rust-clippy#11518 (the title
incorrectly says false positive).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: Fix [
needless_raw_string_hashes]: Continue the lint checking of raw string whenneedless_raw_stringsis allowed.fix #11420