Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove most usage of hir_ty_to_ty #11544

Merged
merged 1 commit into from Sep 21, 2023
Merged

Conversation

Alexendoo
Copy link
Member

Removes the usages where there's a suitable query or the type was already available elsewhere. The remaining cases would all require more involved changes

changelog: none

r? @Jarcho

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 20, 2023
@Jarcho
Copy link
Contributor

Jarcho commented Sep 21, 2023

It would be nice to be able to remove it completely given the number of crashes that come from it.

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 21, 2023

📌 Commit 01c25a8 has been approved by Jarcho

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Sep 21, 2023

⌛ Testing commit 01c25a8 with merge 33f084e...

@bors
Copy link
Collaborator

bors commented Sep 21, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Jarcho
Pushing 33f084e to master...

@bors bors merged commit 33f084e into rust-lang:master Sep 21, 2023
5 checks passed
@Alexendoo Alexendoo deleted the hir-ty-to-ty branch September 21, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants