Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed fp caused by moving &mut reference inside of a closure #11551

Merged
merged 2 commits into from Sep 22, 2023

Conversation

Meczka
Copy link
Contributor

@Meczka Meczka commented Sep 22, 2023

changelog: [needless_pass_by_ref mut]: fixes false positive caused by not covering mutable references passed to a closure inside of a fuction
fixes #11545

@rustbot
Copy link
Collaborator

rustbot commented Sep 22, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @xFrednet (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 22, 2023
@xFrednet
Copy link
Member

Looks good to me, thank you for the nice fix and adding tests :)

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 22, 2023

📌 Commit ab51f66 has been approved by xFrednet

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Sep 22, 2023

⌛ Testing commit ab51f66 with merge 50139e6...

@bors
Copy link
Collaborator

bors commented Sep 22, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing 50139e6 to master...

@bors bors merged commit 50139e6 into rust-lang:master Sep 22, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False Positive: needless_pass_by_ref_mut when mut-requiring use is via closure in async function
4 participants