Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention that missing_assert_message lint ignores test functions #11574

Merged
merged 1 commit into from Sep 28, 2023

Conversation

unexge
Copy link
Contributor

@unexge unexge commented Sep 27, 2023

Updates missing_assert_message's docs to reflect that it ignores test functions as pointed out by @mickvangelderen in #10362 (comment)


changelog: [missing_assert_message]: Update docs to reflect this lint ignores test functions

@rustbot
Copy link
Collaborator

rustbot commented Sep 27, 2023

r? @Alexendoo

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 27, 2023
@Alexendoo
Copy link
Member

Thanks! @bors r+

@bors
Copy link
Collaborator

bors commented Sep 28, 2023

📌 Commit 62b8ef3 has been approved by Alexendoo

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Sep 28, 2023

⌛ Testing commit 62b8ef3 with merge 124f1b0...

@bors
Copy link
Collaborator

bors commented Sep 28, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Alexendoo
Pushing 124f1b0 to master...

@bors bors merged commit 124f1b0 into rust-lang:master Sep 28, 2023
5 checks passed
@unexge unexge deleted the missing-assert-message-docs branch September 28, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants