Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write_literal: Fix index of the remaining positional arguments #11576

Merged
merged 1 commit into from Sep 28, 2023

Conversation

koka831
Copy link
Contributor

@koka831 koka831 commented Sep 28, 2023

changelog: [print_literal], [write_literal]: Now handles positional argument properly

@rustbot
Copy link
Collaborator

rustbot commented Sep 28, 2023

r? @llogiq

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 28, 2023
@llogiq
Copy link
Contributor

llogiq commented Sep 28, 2023

Thanks, this looks good to me. I wonder whether we can also inline other literals beside str. For example the last example could well just write the "2", "3" and "4" literals as part of the format string. Anyway,

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 28, 2023

📌 Commit b413bf6 has been approved by llogiq

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Sep 28, 2023

⌛ Testing commit b413bf6 with merge d18d01a...

@bors
Copy link
Collaborator

bors commented Sep 28, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing d18d01a to master...

@bors bors merged commit d18d01a into rust-lang:master Sep 28, 2023
5 checks passed
@koka831 koka831 deleted the fix/10128 branch September 28, 2023 14:45
@koka831
Copy link
Contributor Author

koka831 commented Sep 29, 2023

Found that Lit::Int (which is now Lit::Integer) and Lit::Float had been ignored by #6335.

I'm not sure should we handle this (at least it can be relaxed by checking lit.chars().all(|c| c.is_ascii_digit())).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cargo clippy --fix broken for positional arguments
4 participants