Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std_instead_of_core: avoid lint inside of proc-macro #11589

Merged
merged 2 commits into from Oct 3, 2023

Conversation

koka831
Copy link
Contributor

@koka831 koka831 commented Sep 30, 2023

note: The lint for the reported thiserror::Error has been suppressed by Don't lint unstable moves in std_instead_of_core because thiserror::Error internally implements std::error::Error for (derived struct).

changelog: [std_intead_of_core]: avoid linting inside proc-macro

I confirmed this change fixes the problem:

test result without the change
error: used import from `std` instead of `core`
  --> tests/ui/std_instead_of_core.rs:65:14
   |
LL |     #[derive(ImplStructWithStdDisplay)]
   |              ^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: this error originates in the derive macro `ImplStructWithStdDisplay` (in Nightly builds, run with -Z macro-backtrace for more info)

@rustbot
Copy link
Collaborator

rustbot commented Sep 30, 2023

r? @giraffate

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 30, 2023
@giraffate
Copy link
Contributor

@bors r+

Thanks!

@bors
Copy link
Collaborator

bors commented Oct 3, 2023

📌 Commit d5cc97e has been approved by giraffate

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Oct 3, 2023

⌛ Testing commit d5cc97e with merge 81400e2...

@bors
Copy link
Collaborator

bors commented Oct 3, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: giraffate
Pushing 81400e2 to master...

@bors bors merged commit 81400e2 into rust-lang:master Oct 3, 2023
5 checks passed
@koka831 koka831 deleted the fix/10198 branch October 4, 2023 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

std_instead_of_core error with thiserror::Error
4 participants