new lint: repeat_vec_with_capacity
#11597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @dswij (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
|
☔ The latest upstream changes (presumably #11791) made this pull request unmergeable. Please resolve the merge conflicts. |
y21
force-pushed
the
repeat_vec_with_capacity
branch
from
5574294
to
3f7dc80
Compare
|
@dswij you wanted me to ping you :) |
|
☔ The latest upstream changes (presumably #11781) made this pull request unmergeable. Please resolve the merge conflicts. |
y21
force-pushed
the
repeat_vec_with_capacity
branch
from
3f7dc80
to
01f40fb
Compare
dswij
reviewed
Dec 1, 2023
| /// ### What it does | ||
| /// Looks for patterns such as `vec![Vec::with_capacity(x); n]` or `iter::repeat(Vec::with_capacity(x))`. | ||
| /// | ||
| /// ### Why is this bad? |
y21
force-pushed
the
repeat_vec_with_capacity
branch
from
01f40fb
to
8c63a3e
Compare
y21
force-pushed
the
repeat_vec_with_capacity
branch
from
8c63a3e
to
76eb781
Compare
dswij
approved these changes
Dec 1, 2023
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
This was referenced Dec 1, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11537
Lint description should explain this PR :)
changelog: new lint:
repeat_vec_with_capacity