[needless_return_with_question_mark]: don't lint if never type is used for coercion

[y21]

Fixes #11616

When we have something like

let _x: String = {
  return Err(())?;
};

we shouldn't suggest removing the return because the !-ness of return is used to coerce the enclosing block to some other type. That will lead to a typeck error without a diverging expression like return.

changelog: [needless_return_with_question_mark]: don't lint if returns never typed-ness is used for coercion

[rustbot]

r? @giraffate

(rustbot has picked a reviewer for you, use r? to override)

[bors]

☔ The latest upstream changes (presumably #11802) made this pull request unmergeable. Please resolve the merge conflicts.

[giraffate]

Sorry for the late reviewing. Can you resolve the conflicts?

[giraffate]

@bors r+

Thanks!

[bors]

📌 Commit a74fa97 has been approved by giraffate

It is now in the queue for this repository.

[bors]

⌛ Testing commit a74fa97 with merge a8b0e5f...

[bors]

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: giraffate
Pushing a8b0e5f to master...