[unnecessary_to_owned
]: catch to_owned
on byte slice to create temporary &str
#11656
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11648
Detects the pattern
&String::from_utf8(bytes.to_vec()).unwrap()
and suggestscore::str::from_utf8(bytes).unwrap()
, which avoids the unnecessary intermediate allocation.I decided to put this in the existing
unnecessary_to_owned
lint (rather than creating a new lint) for a few reasons:to_owned
family, e.g.to_vec
).to_vec()
, so this is in a way similar to the other cases caught byunnecessary_to_owned
, just through a bunch of type conversionsString
typechangelog: [
unnecessary_to_owned
]: catch&String::from_utf8(bytes.to_vec()).unwrap()
and suggestcore::str::from_utf8(bytes).unwrap()