Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ignored_unit_patterns]: check &(), &&(), ... #11670

Merged
merged 1 commit into from Oct 25, 2023

Conversation

lengyijun
Copy link
Contributor

changelog: [ignored_unit_patterns]: check &(), &&(), ...

@rustbot
Copy link
Collaborator

rustbot commented Oct 15, 2023

r? @dswij

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 15, 2023
Copy link
Member

@dswij dswij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you help to add a test for this?

@lengyijun lengyijun force-pushed the ignored_unit_pattern_ref branch 2 times, most recently from 2262b64 to f508d46 Compare October 16, 2023 00:17
@lengyijun lengyijun marked this pull request as draft October 16, 2023 22:39
@lengyijun lengyijun marked this pull request as ready for review October 17, 2023 02:54
Copy link
Member

@dswij dswij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! @lengyijun

@dswij
Copy link
Member

dswij commented Oct 25, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 25, 2023

📌 Commit 536114c has been approved by dswij

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Oct 25, 2023

⌛ Testing commit 536114c with merge 7ce6e0d...

@bors
Copy link
Collaborator

bors commented Oct 25, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: dswij
Pushing 7ce6e0d to master...

@bors bors merged commit 7ce6e0d into rust-lang:master Oct 25, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants