Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Now declare_interior_mutable_const and borrow_interior_mutable_const respect the ignore-interior-mutability configuration entry #11678

Merged
merged 1 commit into from Oct 20, 2023
Merged

Now declare_interior_mutable_const and borrow_interior_mutable_const respect the ignore-interior-mutability configuration entry #11678

merged 1 commit into from Oct 20, 2023

Conversation

slinkydeveloper
Copy link
Contributor

Fix #10537

changelog: Now declare_interior_mutable_const and borrow_interior_mutable_const respect the ignore-interior-mutability configuration entry

@rustbot
Copy link
Collaborator

rustbot commented Oct 16, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 16, 2023
@slinkydeveloper
Now declare_interior_mutable_const and `borrow_interior_mutable_con…
3960bc0 
…st` respect the `ignore-interior-mutability` configuration entry

changelog: Now `declare_interior_mutable_const` and `borrow_interior_mutable_const` respect the `ignore-interior-mutability` configuration entry
Signed-off-by: slinkydeveloper <francescoguard@gmail.com>
@slinkydeveloper
Copy link
Contributor Author

Ping @Alexendoo given you reviewed the #9692

@Manishearth
Copy link
Member

r? @Alexendoo

@rustbot rustbot assigned Alexendoo and unassigned Manishearth Oct 16, 2023
@Alexendoo
Copy link
Member

Thanks! @bors r+

@bors
Copy link
Collaborator

bors commented Oct 20, 2023

📌 Commit 3960bc0 has been approved by Alexendoo

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Oct 20, 2023

⌛ Testing commit 3960bc0 with merge 090df7a...

@bors
Copy link
Collaborator

bors commented Oct 20, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Alexendoo
Pushing 090df7a to master...

@bors bors merged commit 090df7a into rust-lang:master Oct 20, 2023
5 checks passed
This was referenced Nov 19, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alexendoo Alexendoo Alexendoo approved these changes

Assignees

@Alexendoo Alexendoo

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ignore-interior-mutability config doesn't apply to declare_interior_mutable_const
5 participants
@slinkydeveloper @rustbot @Manishearth @Alexendoo @bors