Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in suggestion in iter_without_into_iter.rs #11703

Closed
wants to merge 1 commit into from

Conversation

DannyStoll1
Copy link

A small edit to fix a couple typos in the suggestion in iter_without_into_iter.

Fixes #11692.

@rustbot
Copy link
Collaborator

rustbot commented Oct 24, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @giraffate (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 24, 2023
@y21
Copy link
Member

y21 commented Oct 24, 2023

FYI, there's already an open PR that addresses this (along with some other things mentioned in the linked issue, such as only linting if the type is exported): #11696

As for why this PR is failing checks, you need to update the tests locally that are now failing because of the change in the suggestion (just running cargo uibless should update everything), but not sure if it's worth having two PRs open to fix this?

@giraffate
Copy link
Contributor

I'm closing this in favor of #11696.

Anyway, thanks for opening this!

@giraffate giraffate closed this Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clippy::iter_without_into_iter suggestion does not compile
4 participants