Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the internal_warn lint category #11712

Merged
merged 1 commit into from Oct 26, 2023

Conversation

Alexendoo
Copy link
Member

LINT_AUTHOR and DUMP_HIR can be removed since their corresponding lint passes are only used for side effects

The metadata collector lint can be made an internal lint since clippy::internal is set to deny when running the collector

Also renames some internal lints/passes

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Oct 25, 2023

r? @dswij

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 25, 2023
Copy link
Member

@dswij dswij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Thanks for this!

@dswij
Copy link
Member

dswij commented Oct 26, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 26, 2023

📌 Commit 0580080 has been approved by dswij

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Oct 26, 2023

⌛ Testing commit 0580080 with merge 392b255...

@bors
Copy link
Collaborator

bors commented Oct 26, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: dswij
Pushing 392b255 to master...

@bors bors merged commit 392b255 into rust-lang:master Oct 26, 2023
5 checks passed
@Alexendoo Alexendoo deleted the remove-internal-warn branch October 26, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants