[ptr_arg
]: recognize methods that also exist on slices
#11817
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11816
Not a new lint, just a very small improvement to the existing
ptr_arg
lint which would have caught the linked issue.The problem was that the lint checks if a
Vec
-specific method was called, that is, if the receiver isVec<_>
.This is the case for
len
andis_empty
, however these methods also exist on slices so we can still lint there.This logic exists in a different lint, so we can just reuse that here.
Interestingly, there was even a comment up top that explained what it should have been doing, but the logic for it just wasn't there?
changelog: [
ptr_arg
]: recognize methods that also exist on slicesAlso, this is my 100th PR to clippy 🎉